Skip to content

[GOG]: fix issues with missing games metadata #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

[GOG]: fix issues with missing games metadata #2950

merged 2 commits into from
Aug 9, 2023

Conversation

imLinguin
Copy link
Member

hopefully closes #2237

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:wip WIP, don't merge. label Aug 3, 2023
@imLinguin
Copy link
Member Author

After my testing it seems the game can successfully obtain the metadata on this PR
obraz

@imLinguin imLinguin added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:wip WIP, don't merge. labels Aug 5, 2023
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC and Nocccer and removed request for a team August 5, 2023 14:54
@arielj arielj added this to the 2.9.2 milestone Aug 5, 2023
flavioislima
flavioislima approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@flavioislima flavioislima merged commit bfd7996 into main Aug 9, 2023
@flavioislima flavioislima deleted the improv/gog-lib branch August 9, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

[GOG][Linux] Imperator Rome doesn't show image. Thinks there is an update
3 participants
@imLinguin @flavioislima @arielj